Often Misused: File System

Last revision (mm/dd/yy): //

Vulnerabilities Table of Contents

Description
Passing an inadequately-sized output buffer to a path manipulation function can result in a buffer overflow.

Windows provides a large number of utility functions that manipulate buffers containing filenames. In most cases, the result is returned in a buffer that is passed in as input. (Usually the filename is modified in place.) Most functions require the buffer to be at least MAX_PATH bytes in length, but you should check the documentation for each function individually. If the buffer is not large enough to store the result of the manipulation, a buffer overflow can occur.

Risk Factors
TBD

Examples
char *createOutputDirectory(char *name) { char outputDirectoryName[128]; if (getCurrentDirectory(128, outputDirectoryName) == 0) { return null; }	if (!PathAppend(outputDirectoryName, "output")) { return null; }	if (!PathAppend(outputDirectoryName, name)) { return null; }	if (SHCreateDirectoryEx(NULL, outputDirectoryName, NULL)               != ERROR_SUCCESS) { return null; }	return StrDup(outputDirectoryName); }

In this example the function creates a directory named "output\ " in the current directory and returns a heap-allocated copy of its name. For most values of the current directory and the name parameter, this function will work properly. However, if the name parameter is particularly long, then the second call to PathAppend could overflow the outputDirectoryName buffer, which is smaller than MAX_PATH bytes.

Related Attacks

 * Attack 1
 * Attack 2

Related Vulnerabilities

 * Buffer Overflow

Related Controls

 * Control 1
 * Control 2

Related Technical Impacts

 * Technical Impact 1
 * Technical Impact 2